Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix x-ydb-trace-id #877

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix x-ydb-trace-id #877

merged 1 commit into from
Oct 25, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Oct 25, 2023
@asmyasnikov asmyasnikov marked this pull request as ready for review October 25, 2023 15:07
@github-actions
Copy link

summary

Base version: v3.53.5-0.20231025150820-97be8275370b (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.53.4.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eae4c63) 66.70% compared to head (2274511) 66.90%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   66.70%   66.90%   +0.19%     
==========================================
  Files         255      255              
  Lines       24150    24162      +12     
==========================================
+ Hits        16110    16165      +55     
+ Misses       7200     7166      -34     
+ Partials      840      831       -9     
Flag Coverage Δ
53.57% <40.00%> (+0.33%) ⬆️
go-1.17.x 65.57% <100.00%> (+0.21%) ⬆️
go-1.20.x 66.68% <100.00%> (+0.02%) ⬆️
go-1.21.x 66.85% <100.00%> (+0.19%) ⬆️
integration 53.57% <40.00%> (+0.33%) ⬆️
macOS 39.19% <88.00%> (-0.17%) ⬇️
ubuntu 39.18% <88.00%> (-0.17%) ⬇️
unit 39.28% <88.00%> (-0.18%) ⬇️
windows 39.20% <88.00%> (-0.22%) ⬇️
ydb-22.5 53.05% <40.00%> (-0.03%) ⬇️
ydb-23.1 53.20% <40.00%> (+0.28%) ⬆️
ydb-23.2 53.05% <40.00%> (-0.01%) ⬇️
ydb-23.3 53.07% <40.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/conn/conn.go 74.93% <100.00%> (ø)
internal/meta/context.go 80.00% <100.00%> (+13.33%) ⬆️
internal/meta/trace_id.go 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 7434fce into master Oct 25, 2023
48 of 49 checks passed
@asmyasnikov asmyasnikov deleted the trace-id branch October 25, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants