Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable durationcheck linter #1000

Merged
merged 3 commits into from
Jan 15, 2024
Merged

enable durationcheck linter #1000

merged 3 commits into from
Jan 15, 2024

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #927

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Jan 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (de66cdd) 67.49% compared to head (7a83bf5) 67.39%.

Files Patch % Lines
internal/value/value.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   67.49%   67.39%   -0.10%     
==========================================
  Files         261      261              
  Lines       24686    24686              
==========================================
- Hits        16661    16638      -23     
- Misses       7161     7178      +17     
- Partials      864      870       +6     
Flag Coverage Δ
54.00% <0.00%> (-0.09%) ⬇️
go-1.17.x 65.81% <0.00%> (-0.15%) ⬇️
go-1.20.x 67.39% <0.00%> (+0.01%) ⬆️
go-1.21.x 67.33% <0.00%> (+0.07%) ⬆️
integration 54.00% <0.00%> (-0.09%) ⬇️
macOS 38.80% <0.00%> (+0.01%) ⬆️
ubuntu 38.81% <0.00%> (-0.03%) ⬇️
unit 38.90% <0.00%> (-0.02%) ⬇️
windows 38.88% <0.00%> (ø)
ydb-22.5 53.61% <0.00%> (-0.16%) ⬇️
ydb-23.1 53.73% <0.00%> (-0.07%) ⬇️
ydb-23.2 53.82% <0.00%> (-0.13%) ⬇️
ydb-23.3 53.94% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit a8a7eac into ydb-platform:master Jan 15, 2024
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants