Merge pull request #992 from ydb-platform/promlinter

promlinter enabled
ydb-platform · Dec 31, 2023 · 338d192 · 338d192
2 parents 847aa72 + ce8c48e
commit 338d192
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.golangci.yml b/.golangci.yml
@@ -243,7 +243,6 @@ linters:
     - nonamedreturns
     - nosnakecase
     - paralleltest
-    - promlinter
     - protogetter
     - scopelint
     - structcheck

diff --git a/examples/serverless/url_shortener/service.go b/examples/serverless/url_shortener/service.go
@@ -89,13 +89,15 @@ func getService(ctx context.Context, dsn string, opts ...ydb.Option) (s *service
 			calls    = prometheus.NewGaugeVec(prometheus.GaugeOpts{
 				Namespace: "app",
 				Name:      "calls",
+				Help:      "application calls counter",
 			}, []string{
 				"method",
 				"success",
 			})
 			callsLatency = prometheus.NewHistogramVec(prometheus.HistogramOpts{
 				Namespace: "app",
 				Name:      "latency",
+				Help:      "application calls latencies",
 				Buckets: []float64{
 					(1 * time.Millisecond).Seconds(),
 					(5 * time.Millisecond).Seconds(),
@@ -114,6 +116,7 @@ func getService(ctx context.Context, dsn string, opts ...ydb.Option) (s *service
 			callsErrors = prometheus.NewGaugeVec(prometheus.GaugeOpts{
 				Namespace: "app",
 				Name:      "errors",
+				Help:      "application errors counter",
 			}, []string{
 				"method",
 			})