Skip to content

Commit

Permalink
Merge pull request #1179 from size12/back-comp
Browse files Browse the repository at this point in the history
restored WithSessionPoolKeepAliveMinSize & WithSessionPoolKeepAliveTimeout
  • Loading branch information
asmyasnikov authored Apr 1, 2024
2 parents 304cde8 + c667551 commit 2cd28c9
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* Restored `WithSessionPoolKeepAliveMinSize` and `WithSessionPoolKeepAliveTimeout` for backward compatibility.
* Fixed leak timers
* Changed default StartTime (time of retries for connect to server) for topic writer from 1 minute to infinite (can be overrided by WithWriterStartTimeout topic option)
* Added `Struct` support for `Variant` in `ydb.ParamsBuilder()`
Expand Down
14 changes: 14 additions & 0 deletions options.go
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,20 @@ func WithSessionPoolDeleteTimeout(deleteTimeout time.Duration) Option {
}
}

// WithSessionPoolKeepAliveMinSize set minimum sessions should be keeped alive in table.Client
//
// Deprecated: table client do not support background session keep-aliving now
func WithSessionPoolKeepAliveMinSize(keepAliveMinSize int) Option {
return func(ctx context.Context, c *Driver) error { return nil }
}

// WithSessionPoolKeepAliveTimeout set timeout of keep alive requests for session in table.Client
//
// Deprecated: table client do not support background session keep-aliving now
func WithSessionPoolKeepAliveTimeout(keepAliveTimeout time.Duration) Option {
return func(ctx context.Context, c *Driver) error { return nil }
}

// WithIgnoreTruncated disables errors on truncated flag
func WithIgnoreTruncated() Option {
return func(ctx context.Context, c *Driver) error {
Expand Down

0 comments on commit 2cd28c9

Please sign in to comment.