Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-2371: use pure zap logger #13

Merged
merged 1 commit into from
Dec 25, 2023
Merged

YQ-2371: use pure zap logger #13

merged 1 commit into from
Dec 25, 2023

Conversation

vitalyisaev2
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (8342379) 17.81% compared to head (9700d25) 22.18%.

Files Patch % Lines
app/server/utils/logger.go 13.79% 25 Missing ⚠️
app/server/utils/errors.go 0.00% 4 Missing ⚠️
.../datasource/rdbms/clickhouse/connection_manager.go 0.00% 3 Missing ⚠️
.../server/datasource/rdbms/ydb/connection_manager.go 0.00% 2 Missing ⚠️
.../datasource/rdbms/postgresql/connection_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   17.81%   22.18%   +4.36%     
==========================================
  Files          71       49      -22     
  Lines        6089     4660    -1429     
==========================================
- Hits         1085     1034      -51     
+ Misses       4913     3539    -1374     
+ Partials       91       87       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitalyisaev2 vitalyisaev2 merged commit 658501b into main Dec 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant