Fix sincos implementation to cope with Emscripten #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge-sans-paille
changed the title
serge-sans-paille
force-pushed
the
feature/accurate-sincos
branch
from
b8ceafd to
1678ced
Compare
|
@JohanMabille / @anutosh491 just disabling the #ifdef seems to work, can you explain that? |
serge-sans-paille
force-pushed
the
feature/accurate-sincos
branch
from
eab4a8b to
6e1d892
Compare
|
Looks like the versions of Firefox and the SDKs that we use for testing have changed since we introduced this workaround, maybe the intrinsics have been fixed? Or maybe we are not testing what we think,meaning we don't build with WASM intrinsics, but rather with SSE2 that are then used to generate WASM? This latter seems highly improbable to me, but that's a possibility. |
|
Anyway I double checked the sincos implementation compared to calling sin and cos, and it's exactly the same. |
|
|
|
(I have the feeling that I'm posting this GIF way too often, not a good sign) |
I've double-checked and there is absolutely no difference between calling sin then cos or just sincos. They perform the exact same operation.
serge-sans-paille
force-pushed
the
feature/accurate-sincos
branch
from
6e1d892 to
c3f7bdd
Compare
serge-sans-paille
changed the title
|
@JohanMabille I think it's ok to merge this patch, but I ultimately leave it to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.