-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sqlite.org/sqlite, revert to sync api #988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the async backend is still on a branch,
wasm-backend-async
the OpenMls storage trait is
sync
, so whilexmtp_mls
can be made 100% async (it's mostly async now anyway, other than the db/pool), the openmls trait can not, without significant refactoring of theopenmls
librarywa-sqlite
is advantageous over the official sqlite wasm since its possible to define your own VFS in Javascript. This enables using browser-native APIs like IndexedDb/OPFS/etc or any combination of custom VFS. That's whywa-sqlite
has such an extensive list of VFS' -- it's very flexible. Because of this, however, it exports a strictly async API. it's possible to make this apisync
, but that would offer little benefit over using the normalsqlite
compiled wasm. this also brings the API closer to whats in diesel, enabling more code sharing in the future.the official sqlite wasm defines a sync api and only offers the use of OPFS as a VFS. It supports web workers, too. This fits requirements for getting
xmtp_mls
on web, and makes integration easier since no transition to async for db calls is necessary.diesel-async
,wa-sqlite
sqlite/sqlite-wasm