Remove lots of unwraps #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
commented
Aug 21, 2024
| @@ -1074,7 +1076,11 @@ pub fn build_extensions_for_permissions_update( | |||
| PermissionUpdateType::UpdateMetadata => { | |||
| let mut metadata_policy = existing_policy_set.update_metadata_policy.clone(); | |||
| metadata_policy.insert( | |||
| update_permissions_intent.metadata_field_name.unwrap(), | |||
There was a problem hiding this comment.
this one seems like we could make a default, like unwrap_or("DEFAULT METADATA FIELD NAME") instead of an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of unwraps found with clippy. An unwrap would panic libxmtp and crash the client, so we should never use it unless we are 100% sure it will not panic. Unwrapping in this context may also cause errors to go completely unreported in logs (if a task or something crashes or the logs are not picked up by a logger)
Added a warn lint for
unwrapthat clippy will pick up if ran withouttest,test-utils, orbenchfeature, i.ecargo clippy --no-deps -- -Dwarningsthere are a few unwraps here that could definitely been causing issues/causing crashes in probably less-common circumstances (like the one in insert_or_replace_group and permissions)