Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes some clippy lints #637

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: fixes some clippy lints #637

merged 2 commits into from
Apr 8, 2024

Conversation

tuddman
Copy link
Contributor

@tuddman tuddman commented Apr 8, 2024

No description provided.

@tuddman tuddman requested a review from a team as a code owner April 8, 2024 20:15
@insipx
Copy link
Contributor

insipx commented Apr 8, 2024

don't forget to fmt

Copy link
Contributor

@37ng 37ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few more "the borrowed expression implements the required traits". can these be easily fixed as well?

@tuddman
Copy link
Contributor Author

tuddman commented Apr 8, 2024

there are a few more "the borrowed expression implements the required traits". can these be easily fixed as well?

Yes, they could be easily fixed. However, they are from auto-generated code that will come back whenever we update the protos. I intentionally just left those, despite their annoying persistence.

@tuddman tuddman merged commit 1d9e322 into main Apr 8, 2024
7 checks passed
@tuddman tuddman deleted the st/clippy-lint branch April 8, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants