Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont even have todo. err instead. #607

Merged
merged 1 commit into from
Mar 30, 2024
Merged

fix: dont even have todo. err instead. #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions xmtp_mls/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ pub enum MessageProcessingError {
WrongCredentialType(#[from] BasicCredentialError),
#[error("proto decode error: {0}")]
DecodeError(#[from] prost::DecodeError),
#[error("generic:{0}")]
Generic(String),
}

impl crate::retry::RetryableError for MessageProcessingError {
Expand Down
8 changes: 6 additions & 2 deletions xmtp_mls/src/groups/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ where
conn.set_delivery_status_to_published(&message_id, envelope_timestamp_ns)?;
}
Some(Content::V2(_)) => {
todo!()
return Err(MessageProcessingError::Generic(
"not yet implemented".into(),
))
}
None => return Err(MessageProcessingError::InvalidPayload),
};
Expand Down Expand Up @@ -297,7 +299,9 @@ where
.store(provider.conn())?
}
Some(Content::V2(_)) => {
todo!()
return Err(MessageProcessingError::Generic(
"not yet implemented".into(),
))
}
None => return Err(MessageProcessingError::InvalidPayload),
}
Expand Down
Loading