lint fix rust 1.8.4 #1482
Merged
lint fix rust 1.8.4 #1482
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
commented
Jan 9, 2025
| @@ -456,7 +456,7 @@ struct ExpectedDiff { | |||
| /// [`GroupMembership`] and the [`GroupMembership`] found in the [`StagedCommit`]. | |||
| /// This requires loading the Inbox state from the network. | |||
| /// Satisfies Rule 2 | |||
| async fn extract_expected_diff<'diff>( | |||
There was a problem hiding this comment.
lifetime isn't used
insipx
approved these changes
Jan 9, 2025
codabrink
approved these changes
Jan 9, 2025
cameronvoell
force-pushed
the
cv/01-09-lint_fix_rust_1.8.4
branch
from
631bd11 to
988a468
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
codabrink
reviewed
Jan 9, 2025
| &self, | ||
| conn: &DbConnection, | ||
| inbox_id: InboxIdRef<'a>, | ||
| inbox_id: InboxIdRef<'_>, |
There was a problem hiding this comment.
Suggested change
| inbox_id: InboxIdRef<'_>, | |
| inbox_id: InboxIdRef, |
Would this work?
There was a problem hiding this comment.
without the anonymous lifetime it gives a compiler error:
implicit elided lifetime not allowed here
expected lifetime parameterrustc[Click for full compiler diagnostic](rust-analyzer-diagnostics-view:/diagnostic%20message%20%5B0%5D?0#file%3A%2F%2F%2FUsers%2Fcameronvoell%2FXMTP%2Flibxmtp%2Fxmtp_mls%2Fsrc%2Fgroups%2Fscoped_client.rs)
scoped_client.rs(390, 29): indicate the anonymous lifetime: `<'_>`
cameronvoell
added a commit
that referenced
this pull request
Jan 9, 2025
* revert 404e996 * lint fix rust 1.8.4 (#1482) Co-authored-by: cameronvoell <[email protected]> --------- Co-authored-by: cameronvoell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.