Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation Sitching #1432

Merged
merged 42 commits into from
Dec 21, 2024
Merged

Conversation Sitching #1432

merged 42 commits into from
Dec 21, 2024

Conversation

codabrink
Copy link
Contributor

@codabrink codabrink commented Dec 18, 2024 •
edited
Loading

@codabrink codabrink changed the title Coda/stitching Conversation Sitching Dec 19, 2024
@codabrink codabrink force-pushed the coda/stitching branch 2 times, most recently from 68caaa9 to 3395aa8 Compare December 19, 2024 20:43
@codabrink codabrink linked an issue Dec 19, 2024 that may be closed by this pull request
Proposal: Conversation stitching for DM's #1142
Closed
@codabrink codabrink marked this pull request as ready for review December 19, 2024 22:30
insipx
insipx reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@insipx insipx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, will give a deeper review tomorrow

xmtp_mls/migrations/2024-12-18-170645_add_dm_id/up.sql Outdated Show resolved Hide resolved
@nplasterer
Copy link
Contributor

Can you write up how push notifications will work for this?

If I have a list of conversations and the dms potentially have multiple topics how will I subscribe correctly to push notification topics?

codabrink
codabrink commented Dec 20, 2024
View reviewed changes
xmtp_mls/migrations/2024-12-20-214747_add_dm_id/up.sql
g.installations_last_checked,
g.added_by_inbox_id,
g.welcome_id,
g.dm_id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to recreate the view to account for the column rename dm_inbox_id -> dm_id

insipx
insipx approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@insipx insipx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good other than nit on wasm test

xmtp_mls/src/storage/encrypted_store/mod.rs Outdated Show resolved Hide resolved
@codabrink codabrink enabled auto-merge (squash) December 21, 2024 02:17
@codabrink codabrink merged commit 764c50b into main Dec 21, 2024
15 checks passed
@codabrink codabrink deleted the coda/stitching branch December 21, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani left review comments

@insipx insipx insipx approved these changes

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Conversation stitching for DM's
4 participants
@codabrink @nplasterer @insipx @mchenani