fix: removes unnecessary group_id parameter

xmtp · Aug 1, 2024 · 57b83dd · 57b83dd
1 parent 4296e9c
commit 57b83dd
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/bindings_ffi/src/mls.rs b/bindings_ffi/src/mls.rs
@@ -1219,7 +1219,6 @@ impl FfiGroup {
         let inner_client = Arc::clone(&self.inner_client);
         let handle = MlsGroup::stream_with_callback(
             inner_client,
-            self.group_id.clone(),
             self.created_at_ns,
             move |message| message_callback.on_message(message.into()),
         );

diff --git a/bindings_node/src/groups.rs b/bindings_node/src/groups.rs
@@ -557,7 +557,6 @@ impl NapiGroup {
       callback.create_threadsafe_function(0, |ctx| Ok(vec![ctx.value]))?;
     let stream_closer = MlsGroup::stream_with_callback(
       self.inner_client.clone(),
-      self.group_id.clone(),
       self.created_at_ns,
       move |message| {
         tsfn.call(Ok(message.into()), ThreadsafeFunctionCallMode::Blocking);

diff --git a/xmtp_mls/src/groups/subscriptions.rs b/xmtp_mls/src/groups/subscriptions.rs
@@ -116,8 +116,8 @@ impl MlsGroup {
     }
 
     pub fn stream_with_callback<ApiClient>(
+        &self,
         client: Arc<Client<ApiClient>>,
-        group_id: Vec<u8>,
         created_at_ns: i64,
         callback: impl FnMut(StoredGroupMessage) + Send + 'static,
     ) -> StreamHandle<Result<(), crate::groups::ClientError>>
@@ -127,7 +127,7 @@ impl MlsGroup {
         Client::<ApiClient>::stream_messages_with_callback(
             client,
             HashMap::from([(
-                group_id,
+                self.group_id.clone(),
                 MessagesStreamInfo {
                     convo_created_at_ns: created_at_ns,
                     cursor: 0,