Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re enable arg helper_crd #334

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Re enable arg helper_crd #334

merged 2 commits into from
Feb 29, 2024

Conversation

312hzeng
Copy link
Collaborator

  • Re-enable helper_crd as a flag
  • Allow users to provide a helper_crd file for Acto to test with

@tylergu tylergu merged commit 53aa9e6 into xlab-uiuc:main Feb 29, 2024
4 checks passed
@sallyr0823
Copy link

@tylergu @312hzeng In acto/acto/main.py, default value of helper_crd should be set to None. Otherwise file not found error happens

@tylergu
Copy link
Member

tylergu commented Feb 29, 2024

Sorry I oversaw this, let me fix right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@312hzeng @sallyr0823 @tylergu