Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[epilogue] Add a measure's symbol to its name when logged by Epilogue (#7535)" #7652

Merged

Conversation

oh-yes-0-fps
Copy link
Contributor

This reverts commit 469bb32.

@oh-yes-0-fps oh-yes-0-fps requested a review from a team as a code owner January 7, 2025 17:48
@github-actions github-actions bot added the component: epilogue Annotation-based logging library label Jan 7, 2025
Copy link
Contributor Author

@oh-yes-0-fps oh-yes-0-fps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR had issues due to the fact unit symbols often times had / in them causing issues with nt topic visualization.
The PR also introduced excessive string concatenation for logging measures

@PeterJohnson PeterJohnson merged commit 995bc98 into wpilibsuite:main Jan 7, 2025
45 checks passed
pjreiniger pushed a commit to bzlmodRio/allwpilib that referenced this pull request Jan 8, 2025
…Epilogue (wpilibsuite#7535)" (wpilibsuite#7652)

This reverts commit 469bb32.

The approach used has issues due to the fact unit symbols often have a literal / in them,
which causes issues with NT topic visualization.

A better approach would be to use topic metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: epilogue Annotation-based logging library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants