Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Martinh/ntt solana models deployment #193

Merged
merged 11 commits into from
Jan 13, 2025
Merged

Martinh/ntt solana models deployment #193

merged 11 commits into from
Jan 13, 2025

Conversation

martin0995
Copy link
Collaborator

Description

Updated the NTT Solana Deployment page to clarify the different steps for deploying NTT for models (hub&spoke and burn&mint).

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Jan 10, 2025
@martin0995 martin0995 requested a review from evgeniko January 10, 2025 18:01
eshaben
eshaben reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this page is kind of confusing. I think we've been adding stuff here and there, but it could benefit from taking a step back and seeing how the whole page flows and what details we're missing.

build/contract-integrations/native-token-transfers/deployment-process/deploy-to-solana.md Outdated Show resolved Hide resolved
build/contract-integrations/native-token-transfers/deployment-process/deploy-to-solana.md Outdated Show resolved Hide resolved
@martin0995 martin0995 requested a review from eshaben January 13, 2025 16:50
eshaben
eshaben approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this with the intention of reevaluating this page later ✨

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 13, 2025
@martin0995 martin0995 merged commit cebe262 into main Jan 13, 2025
1 check passed
@martin0995 martin0995 deleted the martinh/ntt-solana-models-deployment branch January 13, 2025 17:19
This was referenced Jan 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeniko evgeniko evgeniko left review comments

@eshaben eshaben eshaben approved these changes

@dawnkelly09 dawnkelly09 Awaiting requested review from dawnkelly09 dawnkelly09 is a code owner

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin0995 @eshaben @evgeniko