-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana: Multi Transceiver Support #528
Conversation
SDK currently doesn't support multi-transceiver (it takes in a transceiver address at initialization and doesn't use it after that). Current TS changes are the minimum necessary to be able to test a custom transceiver. One potential solution is to add a map/list for transceivers in the |
this would be the most comprehensive solution, but might make sense to tackle it in a separate PR |
That makes sense, I'll make a new PR that is based on this to implement the TS SDK refactor. At the end, we can merge both PRs together. |
The TS SDK refactor is complete (with all CI jobs accounted for) and the PR is ready for review: #535 🎉 I think it makes chronological sense to review this PR first and then the TS SDK refactor PR as those changes are based off this. |
b563f3a
to
a3517b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff!
3472e55
to
e942102
Compare
…eiverMessageData`
* Update Ntt and NttTransceiver interfaces to be more generic * Update SolanaNtt to store a list of Program<NttBindings.Transceiver<IdlVersion>>. This mimics EvmNtt which stores list of EvmNttWormholeTranceiver. * Reserve transceiver at index 0 for Wormhole transceiver in Solana and EVM * Refactor transceiver specific functions into SolanaNttWormholeTransceiver * Add Wormhole-specific wrapper methods and anchor-idl 3.0.0 bindings for backwards compatibility
e942102
to
4940a05
Compare
src/transceivers/*
andsrc/messages.rs
from Manager intontt-transceiver
programValidatedTransceiverMessage
in Managerrelease_outbound
ix to CPI into Manager'smark_outbox_item_as_released
ix.Makefile
to remove generics (if exists) from all programs