-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme: add Solana message lifecycle #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-suri
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left comments for rephrasing certain sections.
Still need to review the final couple receive steps -- redeem
and Mint or unlock
bingyuyap
force-pushed
the
bing/solana-readme
branch
2 times, most recently
from
March 4, 2024 16:59
6377863
to
b27afae
Compare
kcsongor
reviewed
Mar 4, 2024
kcsongor
reviewed
Mar 4, 2024
kcsongor
previously approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
bingyuyap
force-pushed
the
bing/solana-readme
branch
from
March 5, 2024 01:05
b27afae
to
7337f24
Compare
kcsongor
approved these changes
Mar 5, 2024
kcsongor
force-pushed
the
bing/solana-readme
branch
2 times, most recently
from
March 6, 2024 13:24
17c3dcb
to
18d02f1
Compare
Signed-off-by: bingyuyap <[email protected]>
kcsongor
force-pushed
the
bing/solana-readme
branch
from
March 6, 2024 13:50
18d02f1
to
da9369a
Compare
RahulMaganti47
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.