Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of monero_wallet_light #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

everoddandeven
Copy link

@everoddandeven everoddandeven commented Oct 1, 2024

This pull request introduces a new class, monero_wallet_light, which is designed to facilitate the connection and interaction with Monero light wallet servers. The monero_wallet_light class provides essential functionalities such as:

  1. Connecting to a light wallet server to fetch wallet data without needing the full blockchain.
  2. Synchronizing wallet balances and transactions in a lightweight manner.
  3. Sending transactions through the light wallet server.
  4. Querying necessary blockchain information from the server.
  5. The purpose of this implementation is to improve the user experience for devices with limited resources, such as mobile devices, by offloading blockchain-heavy operations to remote light wallet servers.

Closes #58

@woodser
Copy link
Owner

woodser commented Oct 3, 2024

Getting this warnings on the build:

/Users/woodser/git/monero-java/external/monero-cpp/src/wallet/monero_wallet_light.cpp:1368:11: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
      if (!kv.first == account_index) continue;
          ^         ~~
/Users/woodser/git/monero-java/external/monero-cpp/src/wallet/monero_wallet_light.cpp:1368:11: note: add parentheses after the '!' to evaluate the comparison first
      if (!kv.first == account_index) continue;
          ^
           (                        )
/Users/woodser/git/monero-java/external/monero-cpp/src/wallet/monero_wallet_light.cpp:1368:11: note: add parentheses around left hand side expression to silence this warning
      if (!kv.first == account_index) continue;
          ^
          (        )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants