Skip to content

Commit

Permalink
lib data model services: Bump PHPMD version 2.15
Browse files Browse the repository at this point in the history
The newer version of the tool (pulled by the existing
dependency compatibility range) seems to find some
issues that older version(s) didn't.
This change makes the new version dependency more
explicit, and temporarily disables identified
issues.

Bug: T381168
Change-Id: I229749887fcc930f6f598babdfe25242df1c8021
  • Loading branch information
manicki authored and WMDE bot committed Jan 22, 2025
1 parent a38367b commit a718b0a
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"wikimedia/assert": "~0.2.2|~0.3.0|~0.4.0|~0.5.0"
},
"require-dev": {
"phpmd/phpmd": "~2.3",
"phpmd/phpmd": "~2.15",
"phpunit/phpunit": "~8.0"
},
"autoload": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
*
* @license GPL-2.0-or-later
* @author Marius Hoch
*
* @SuppressWarnings(PHPMD.LongClassName)
*/
class EntityRetrievingClosestReferencedEntityIdLookup implements ReferencedEntityIdLookup {

Expand Down
2 changes: 2 additions & 0 deletions src/Lookup/MaxReferencedEntityVisitsExhaustedException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
*
* @license GPL-2.0-or-later
* @author Marius Hoch
*
* @SuppressWarnings(PHPMD.LongClassName)
*/
class MaxReferencedEntityVisitsExhaustedException extends ReferencedEntityIdLookupException {

Expand Down
2 changes: 2 additions & 0 deletions tests/unit/Diff/Internal/AliasGroupListPatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*
* @license GPL-2.0-or-later
* @author Bene* < [email protected] >
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
class AliasGroupListPatcherTest extends TestCase {

Expand Down
2 changes: 2 additions & 0 deletions tests/unit/Diff/TermListPatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*
* @license GPL-2.0-or-later
* @author Bene* < [email protected] >
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
class TermListPatcherTest extends TestCase {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
*
* @license GPL-2.0-or-later
* @author Marius Hoch
*
* @SuppressWarnings(PHPMD.LongClassName)
*/
class EntityRetrievingClosestReferencedEntityIdLookupTest extends TestCase {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
*
* @license GPL-2.0-or-later
* @author Marius Hoch
*
* @SuppressWarnings(PHPMD.LongClassName)
*/
class MaxReferencedEntityVisitsExhaustedExceptionTest extends TestCase {

Expand Down

0 comments on commit a718b0a

Please sign in to comment.