Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RN 73 #7844

Merged
merged 21 commits into from
Feb 18, 2024
Merged

Support RN 73 #7844

merged 21 commits into from
Feb 18, 2024

Conversation

gosha212
Copy link
Contributor

No description provided.

@gosha212 gosha212 linked an issue Feb 11, 2024 that may be closed by this pull request
[Epic] React Native 73 Support #7834
Open
3 tasks
@gosha212 gosha212 changed the title Make Android build with RN 73 Support RN 73 Feb 11, 2024
@gosha212 gosha212 mentioned this pull request Feb 11, 2024
Closed
@asafkorem asafkorem force-pushed the feature/7834-epic-react-native-73-support branch from 5c09811 to 000cc9e Compare February 16, 2024 12:34
@gosha212 gosha212 marked this pull request as ready for review February 18, 2024 08:47
@gosha212 gosha212 requested a review from d4vidi February 18, 2024 08:48
d4vidi
d4vidi reviewed Feb 18, 2024
View reviewed changes
.buildkite/pipeline.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorgn this is not cool... we need to bring back the config to our end, as with Detox

d4vidi
d4vidi approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's break in mind that the next release will require everyone to switch to Java17 - we could link up a setup guide etc.

@gosha212 gosha212 merged commit 0be34f9 into master Feb 18, 2024
4 of 5 checks passed
gosha212 added a commit that referenced this pull request Feb 20, 2024
@gosha212
Revert "Support RN 73 (#7844)"
50b7040 
This reverts commit 0be34f9.
@gosha212 gosha212 mentioned this pull request Feb 20, 2024
Merged
asafkorem added a commit that referenced this pull request Feb 23, 2024
@gosha212 @asafkorem
fix: revert #7844 (React Native 73 support) (#7851)
1b3d04f 
* Revert "Support RN 73 (#7844)"

This reverts commit 0be34f9.

* Revert "Revert "build(fix): patch boost podspec on post-install. (#7829)" (#7850)"

This reverts commit fd0edce.

* build(iOS): move pre-pod-install script to Podfile.

---------

Co-authored-by: Asaf Korem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4vidi d4vidi d4vidi approved these changes

Assignees
No one assigned
Labels
type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic] React Native 73 Support
3 participants
@gosha212 @d4vidi @asafkorem