Specify UTC time in Calendar widget #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah ok I see, the |
|
I’m surprised that AddThisEvent wants the time in that format rather than ISO8601. Is that a quirk of their service? |
|
I think you have to create an account/log in to see any developer docs, so I couldn't be bothered to look. I agree it's a bit odd. |
|
LGTM |
|
Actually, @calumgunn one further suggestion — is there any sense in moving the utc conversion into the helper? |
|
@jgwhite Yes, there is. |
|
Eres un hombre muy juicioso. |
calumgunn
added a commit
that referenced
this pull request
Apr 2, 2015
Specify UTC time in Calendar widget
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nails #58.