-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PlainSocketFactory and make it a default fallback #2
base: master
Are you sure you want to change the base?
Conversation
Hi Darkyenus, for me AnonymousSslSocketFactoryTest are failing.
|
It has been a long time, so I no longer remember how exactly did the code work or how to fix your problem. However, it is possible that the problem you encountered is the same as #1, for which this is a workaround. If it is the case (and I suspect that it is), the test is failing because you are using too recent JRE which no longer supports anonymous ciphers ( |
I am using it with Java 8. I am not an expert in this area, what do you suggest here to bypass this problem. Should I remove AnonymousSslSocketFactory in total or maybe remove setting of EnabledCipherSuites? |
I don't know what is your final goal, but if you just want to use the plugin, you can use my branch directly and just ignore the failed test, the code (in my branch) is structured in a way that can deal with that functionality being broken, I think. |
Result of #1. Adds
PlainSocketFactory
, which is a simplified version ofAnonymousSslSocketFactory
without any SSL - just through plain sockets. This new socket factory is then made default fallback, instead of the anonymous one, which is still available through environment key. All tests are passing.After a few hours of messing with proxies and RMI, I am so happy I found this project. Thank you for creating and publishing it!