Major Refactor #40
Merged
Major Refactor #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-rice
force-pushed
the
wr-refactor
branch
from
a738165 to
8088adf
Compare
parent 03845a5 author Will <[email protected]> 1728870664 -0400 committer Will <[email protected]> 1732659637 -0500 parent 03845a5 author Will <[email protected]> 1728870664 -0400 committer Will <[email protected]> 1732659617 -0500 parent 03845a5 author Will <[email protected]> 1728870664 -0400 committer Will <[email protected]> 1732659576 -0500 parent 03845a5 author Will <[email protected]> 1728870664 -0400 committer Will <[email protected]> 1732659547 -0500 parent 03845a5 author Will <[email protected]> 1728870664 -0400 committer Will <[email protected]> 1732659503 -0500 parent 03845a5 author Will <[email protected]> 1728870664 -0400 committer Will <[email protected]> 1732659433 -0500 Major Refactor
will-rice
force-pushed
the
wr-refactor
branch
from
8088adf to
f2da4bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a lot of changes pushed in this commit. I won't release it until I have updated the huggingface hub models to be compatible. One of the main things I updated is the training framework. Before, there was a lightning module for each model, now I have a single lightning module for all models. This should make it more straightforward to add additional models.