Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#244] drop explicit dependency on jboss-logging #245

Merged
merged 1 commit into from
Jan 6, 2025
+7 −12
Merged

[#244] drop explicit dependency on jboss-logging #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Changelog

## 2.0.4 (not yet released)
## 2.1.0 (not yet released)

- dropped explicit dependency on `jboss-logging`

## 2.0.3 (2024-09-16)

Expand Down
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ __You have to provide both `*-controller-client` and `*-cli` yourself.__
If you want to use commands for patching, you also have to provide
`wildfly-patching`.

You might need to tweak other dependencies to transitively bring
compatible `jboss-logging` from `wildfly-core` or explicitly provide
compatible version. WildFly 34 and newer requires at least `3.6.0`.

Other dependencies might be required if you're using "local" CLI operations,
such as `jms-queue add ...` on WildFly 10 (it was a built-in operation
in previous WildFly versions, but was moved to a separate module due to
Expand Down Expand Up @@ -641,7 +645,6 @@ on Creaper:

- `creaper-core`:
- `com.google.guava:guava`
- `org.jboss.logging:jboss-logging`
- `creaper-commands`:
- everything from `creaper-core`
- `org.codehaus.groovy:groovy`
Expand Down
4 changes: 0 additions & 4 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
<groupId>org.wildfly.core</groupId>
<artifactId>wildfly-cli</artifactId>
</dependency>
<dependency>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging</artifactId>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
6 changes: 0 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@
<version.org.jboss.arquillian>1.6.0.Final</version.org.jboss.arquillian>
<!-- EAP 7.0.0 (WildFly 10) -->
<version.org.wildfly.core.wildfly-everything>2.2.0.Final</version.org.wildfly.core.wildfly-everything>
<version.org.jboss.logging.jboss-logging>3.3.0.Final</version.org.jboss.logging.jboss-logging>
<version.org.jboss.modules.jboss-modules>2.0.3.Final</version.org.jboss.modules.jboss-modules>
<version.org.jboss.shrinkwrap>1.2.6</version.org.jboss.shrinkwrap>
<version.org.mockito.mockito-core>4.6.1</version.org.mockito.mockito-core>
Expand Down Expand Up @@ -152,11 +151,6 @@
<version>${version.org.wildfly.core.wildfly-everything}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging</artifactId>
<version>${version.org.jboss.logging.jboss-logging}</version>
</dependency>
<!--
- Somehow a dependency on a non-existing version of JBoss Modules creeps into the testsuite.
- Forcing a correct and existing version here to avoid Maven always trying to download the wrong one.
Expand Down
Loading