Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contestant number (order) for WSContest contest page #70

Closed
wants to merge 1 commit into from
Closed

Added contestant number (order) for WSContest contest page #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion templates/contests_view.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<caption style="caption-side: top">{{ msg('scores-legend', [score_calculation_interval~'']) }}</caption>
<thead>
<tr>
<th>{{ msg('rank') }}</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rank message needs to be added to i18n/en.json and i18n/qqq.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I got your point, submitting the updated patch very soon! Thanks for your guidance.

<th>{{ msg('user') }}</th>
<th>{{ msg('points') }}</th>
<th>{{ msg('contributions') }}</th>
Expand All @@ -63,8 +64,9 @@
</tr>
</thead>
<tbody>
{% for score in scores %}
{% for index, score in scores %}
<tr>
<td>{{ index + 1 }}</td>
<td><a href="https://meta.wikimedia.org/wiki/User:{{ score.username }}">{{ score.username }}</a></td>
<td>{{ score.points }}</td>
<td>{{ score.contributions }}</td>
Expand Down