Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice Over fixes #5161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Voice Over fixes #5161

wants to merge 2 commits into from
+37 −23

Conversation

mazevedofs
Copy link
Collaborator

@mazevedofs mazevedofs commented Jan 22, 2025 •
edited
Loading

Phabricator: https://phabricator.wikimedia.org/T383453

Notes

  • I couldn't find any other VoiceOver bugs related to the nav bar
  • The header accessibility trait didn't provide any extra context on VoiceOverin this case, so I kept the static text trait
  • added a fix for the profile badge update

Test Steps

  1. Run voice over on the app. Focus on navigation bar issues
  2. We can rely on QA for more comprehensive scenarios
  3. On explore feed and article view, make sure the accessibility label properly updates when you go from a badge to a no badge state

@mazevedofs mazevedofs requested review from a team and l-olson1214 and removed request for a team January 22, 2025 15:04
@l-olson1214
Copy link
Collaborator

Not sure if this is relevant to THIS ticket but I'm getting "profile with unread badge" even if I don't have any unreads

@mazevedofs mazevedofs changed the title Set accessibility trait of left bar button item on navigation bar to static text Voice Over fixes Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-olson1214 l-olson1214 l-olson1214 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazevedofs @l-olson1214