-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep Link support added for places #4986
Open
raihan
wants to merge
5
commits into
wikimedia:main
Choose a base branch
from
raihan:deep-link-support-for-places
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8d81fb2
Deep link support added for location with name and coordinates
raihan efe913b
coordinates prioritized over name
raihan 07e3588
improved readability
raihan 8c14c2c
Merge branch 'main' into deep-link-support-for-places
raihan 2c49afe
Merge branch 'main' into deep-link-support-for-places
raihan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1215,9 +1215,21 @@ - (BOOL)processUserActivity:(NSUserActivity *)activity animated:(BOOL)animated c | |
[self.currentTabNavigationController popToRootViewControllerAnimated:animated]; | ||
NSURL *articleURL = activity.wmf_linkURL; | ||
if (articleURL) { | ||
// For "View on a map" action to succeed, view mode has to be set to map. | ||
[[self placesViewController] updateViewModeToMap]; | ||
[[self placesViewController] showArticleURL:articleURL]; | ||
double latitude = [[articleURL wmf_valueForQueryKey:@"latitude"] doubleValue]; | ||
double longitude = [[articleURL wmf_valueForQueryKey:@"longitude"] doubleValue]; | ||
NSString *place = [articleURL wmf_valueForQueryKey:@"place"]; | ||
|
||
if (latitude && longitude) { | ||
// If the place coordinate is provided in the URL, show it in the map | ||
[[self placesViewController] searchPlaceWithCoordinateWithLatitude:latitude longitude:longitude]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not able to hit this condition - I think the latitude and longitude values are getting dropped somewhere. |
||
} else if (place) { | ||
// If the place name is provided in the URL, show it in the map | ||
[[self placesViewController] searchForPlaceWithName:place]; | ||
} else { | ||
// For "View on a map" action to succeed, view mode has to be set to map. | ||
[[self placesViewController] updateViewModeToMap]; | ||
[[self placesViewController] showArticleURL:articleURL]; | ||
} | ||
} | ||
} break; | ||
case WMFUserActivityTypeContent: { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Optional)
This may be tricky to fix, but I would prefer if we removed the whole
WMFArticleURL=
part of these places deep links:It is unnecessary information, and indicates we are searching against the subdomain wiki (
en.wikipedia.org
), when in reality the app searches against the primary app language wiki in Settings.If you could find a way to get these two links to work instead:
I think that would feel better.