refactor!: add module support and take out import maps from widgets (ipyesm) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariobuikhuizen
approved these changes
Feb 6, 2024
maartenbreddels
force-pushed
the
refactor_ipyesm
branch
2 times, most recently
from
db0ff2b to
a4e1cc5
Compare
This should be the pre-cursor to what should become ipyesm, which could be a separate package that ipyvue, ipyreact and possibly anywidget could depend on and use. Note that the interface is declerative (you do not explicitly create widgets), which allows Solara (or other frameworks that render widgets to handle the import maps and esm loading in a different way.) For instance, solara could add a import map DOM element, and load the ESM modules via a script tag.
Although initially this worked well, we do not know if we want to load from a module, or from esm.sh. Instead, we can have the default import map make MUI and confetti-canvas work.
maartenbreddels
force-pushed
the
refactor_ipyesm
branch
from
a4e1cc5 to
e05d527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the precursor to what should become ipyesm, which could be a separate package that ipyvue, ipyreact, and possibly anywidget (cc @manzt) could depend on and use.
Note that the interface is declerative (you do not explicitly create widgets), which allows Solara (or other frameworks that render widgets to handle the import maps and esm loading in a different way.)
For instance, solara could add a import map DOM element, and load the ESM modules via a script tag.