Skip to content

Commit

Permalink
Make langkit optional
Browse files Browse the repository at this point in the history
It was getting pulled in for the regular container when it shouldn't be
and bloating the image size.
  • Loading branch information
naddeoa committed Jan 31, 2024
1 parent 524effe commit f0fdcda
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 37 deletions.
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ build: $(src)
publish: build
poetry publish

lint: ## Check for type issues with pyright
poetry run pyright

test: ## Run unit tests
poetry run pytest

Expand Down
63 changes: 33 additions & 30 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "whylogs-container-types"
version = "0.4.8"
version = "0.5.0"
description = ""
authors = ["Anthony Naddeo <[email protected]>"]
license = "MIT"
Expand All @@ -10,13 +10,16 @@ packages = [{ include = "whylogs_container_types/**/*.py" }]
[tool.poetry.dependencies]
python = "^3.8"
whylogs = "*"
langkit = "*"
langkit = { "version" = "*", "optional" = true }


[tool.poetry.group.dev.dependencies]
pyright = "^1.1.337"
ruff = "^0.1.13"

[tool.poetry.extras]
llm = ["langkit"]

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
Expand All @@ -25,7 +28,7 @@ build-backend = "poetry.core.masonry.api"
Homepage = "https://github.com/whylabs/whylogs-container-types"

[tool.pyright]
include = ["whylogs_container_types", "integ"] # TODO add tests to this also once we fix their types
include = ["whylogs_container_types"]
typeCheckingMode = "strict"

reportMissingTypeStubs = false
Expand All @@ -35,7 +38,7 @@ reportMissingTypeArgumet = false
[tool.ruff]
line-length = 140
indent-width = 4
include = ["./whylogs_container_types/**/*.py", "./tests/**/*.py", "./integ/**/*.py"]
include = ["./whylogs_container_types/**/*.py"]
select = ["E", "F", "I", "W"]

[tool.ruff.isort]
Expand Down

0 comments on commit f0fdcda

Please sign in to comment.