Issue 498: Integrate the Churn Gem and Write a Learning Test to Understand Parts of the Interface RubyCritic Cares About

[hemalvarambhia]

Issue: #498
Check list:

• Add an entry to the changelog
• Squash all commits into a single one
• Describe your PR, link issues, etc.

[hemalvarambhia]

Interesting! I ran git log -1 ... as follows

git log -1 --date=iso --follow --format='format:%H date:%x09%ad' -- lib/rubycritic/report_generators/reporter.rb

and the last commit made to file in the test (lib/rubycritic/report_generators/reporter.rb) was:

6733757b8ad103785f464c32381c5681c723888e date: 2014-05-15 00:28:35 +0100

when it was deleted.

The test in question (test/lib/rubycritic/source_control_systems/git/churn_test.rb:31) says that the last commit involving the file is '2014-03-19 18:17:28 +0000'. What am I missing?

[hemalvarambhia]

@etagwerker so far, how does the work presented here look? Is there more I need to do?

[etagwerker]

@hemalvarambhia I think this is headed in a good direction. Are you planning to change the implementation of the churn calculation next?

[hemalvarambhia]

@hemalvarambhia I think this is headed in a good direction. Are you planning to change the implementation of the churn calculation next?

@etagwerker yes, I wanted to spend some time feeling confident working with the code, making sure I understand how to change it within its current architecture. Does that make sense?

[etagwerker]

@hemalvarambhia That makes sense. Go for it. 👍🏼

[hemalvarambhia]

I'll be back on this PR in a bit. Exploring some tools in python. Please bear with me.