Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PLTs from Hex package #256

Merged
merged 3 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
- otp: "26.0.1"
elixir: "1.15.0"
version-type: strict
dialyzer: true

- otp: "25.3"
elixir: "1.14.3"
Expand Down Expand Up @@ -62,19 +63,22 @@ jobs:
# Don't cache PLTs based on mix.lock hash, as Dialyzer can incrementally update even old ones
# Cache key based on Elixir & Erlang version (also useful when running in matrix)
- name: Cache Dialyzer's PLT
if: ${{ matrix.dialyzer }}
uses: actions/cache@v3
id: cache-plt
with:
path: priv/plts
path: plts
key: |
plt-${{ runner.os }}-otp${{ matrix.otp }}-elixir${{ matrix.elixir }}-${{ hashFiles('**/mix.lock') }}
restore-keys: |
plt-${{ runner.os }}-otp${{ matrix.otp }}-elixir${{ matrix.elixir }}-

# Create PLTs if no cache was found
- name: Create PLTs
if: steps.cache-plt.outputs.cache-hit != 'true'
run: mix dialyzer --plt
if: steps.cache-plt.outputs.cache-hit != 'true' && matrix.dialyzer
run: |
mkdir -p plts
mix dialyzer --plt

- name: Check formatting
run: mix format --check-formatted
Expand All @@ -98,6 +102,7 @@ jobs:

- name: Run dialyzer
run: mix dialyzer --format github
if: ${{ matrix.dialyzer }}

- name: Dump Docker logs on failure
uses: jwalton/gh-docker-logs@v1
Expand Down
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ erl_crash.dump
/bench/graphs/index.html
/cover
/doc
/priv/plts/*.plt
/priv/plts/*.plt.hash
/plts
12 changes: 8 additions & 4 deletions mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ defmodule Redix.Mixfile do

# Dialyzer
dialyzer: [
plt_local_path: "priv/plts",
plt_core_path: "priv/plts"
plt_local_path: "plts",
plt_core_path: "plts"
],

# Hex
Expand Down Expand Up @@ -66,11 +66,15 @@ defmodule Redix.Mixfile do
{:nimble_options, "~> 0.5.0 or ~> 1.0"},

# Dev and test dependencies
{:dialyxir, "~> 1.1.0", only: [:dev, :test], runtime: false},
{:ex_doc, "~> 0.28", only: :dev},
{:excoveralls, "~> 0.17", only: :test},
{:propcheck, "~> 1.1", only: :test},
{:stream_data, "~> 0.4", only: [:dev, :test]}
]
] ++
if Version.match?(System.version(), "~> 1.12") do
[{:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false}]
else
[]
end
end
end
2 changes: 1 addition & 1 deletion mix.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
%{
"castore": {:hex, :castore, "1.0.3", "7130ba6d24c8424014194676d608cb989f62ef8039efd50ff4b3f33286d06db8", [:mix], [], "hexpm", "680ab01ef5d15b161ed6a95449fac5c6b8f60055677a8e79acf01b27baa4390b"},
"dialyxir": {:hex, :dialyxir, "1.1.0", "c5aab0d6e71e5522e77beff7ba9e08f8e02bad90dfbeffae60eaf0cb47e29488", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "07ea8e49c45f15264ebe6d5b93799d4dd56a44036cf42d0ad9c960bc266c0b9a"},
"dialyxir": {:hex, :dialyxir, "1.4.1", "a22ed1e7bd3a3e3f197b68d806ef66acb61ee8f57b3ac85fc5d57354c5482a93", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "84b795d6d7796297cca5a3118444b80c7d94f7ce247d49886e7c291e1ae49801"},
"earmark_parser": {:hex, :earmark_parser, "1.4.25", "2024618731c55ebfcc5439d756852ec4e85978a39d0d58593763924d9a15916f", [:mix], [], "hexpm", "56749c5e1c59447f7b7a23ddb235e4b3defe276afc220a6227237f3efe83f51e"},
"erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
"ex_doc": {:hex, :ex_doc, "0.28.4", "001a0ea6beac2f810f1abc3dbf4b123e9593eaa5f00dd13ded024eae7c523298", [:mix], [{:earmark_parser, "~> 1.4.19", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1", [hex: :makeup_erlang, repo: "hexpm", optional: false]}], "hexpm", "bf85d003dd34911d89c8ddb8bda1a958af3471a274a4c2150a9c01c78ac3f8ed"},
Expand Down
Empty file removed priv/plts/.gitkeep
Empty file.