Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11
What I did
return self
on bothset()
andsave()
, allowing these two methods to be chained as an alternative tosetsave()
set().save()
works as expectedsetsave()
setsave()
calls inYAMLSettings
andTOMLSettings
, as well as inJSONSettings
, since they weren't passing theoption
andvalue
arguments to thesuper
call. This was uncovered after adding the test forsetsave
mentioned above.At this point I haven't removed the
setsave
method (in case it should remain for compatibility reasons), and I haven't (yet) made any changes to the README, changelog or docs, but I could do if needed!How to test
I added two new tests to
test_settingsbase
, all tests should pass withpytest