-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dashboards search #4781
base: main
Are you sure you want to change the base?
feat: Dashboards search #4781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- On first login I see this bad layout, refresh works fine:
-
Why on the side? Header seems appropriate because what's below it is what you're filtering and tabbing after search would work. Right now tab after search goes to left nav. And it's just odd.. you look at projects, then want to filter so you go to a different panel.
-
I think related to the new login with secret, type 0000, hit enter, and enter selects Google instead of submitting the pass
|
|
|
Reagrding accessibility with tab - yeah not sure, next tabbable in line is navigation, but yeah after searching something you might want to tab into found items |
Actually just realized why The search position looks weird, its because I didn't show search results from all things, but just stayed in the same view, e.g. projects or templates. The current position of search actually requires to show a new view, "search", which would show all things in one view. Not sure if I should move the search for now to the header or add the search view. Search view is better long-term. |
I think I am gonna add the search view now, its not hard. |
Another alternative could be using cmd+k interface here like we do in the builder, clicking on search would open cmd+k panel .... |
Hmm, problem is in this case search needs to either have all data loaded upfront or be done server-side. |
Hmm, ok I think I am going to do the following:
|
Description
Steps for reproduction
Code Review
Before requesting a review
Before merging
.env
file