feat: single-linked list for resolver stack #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of
doResolve
by representing the resolver stack via a singly-linked list instead of aSet<string>
. Profiling indicated that a significant amount of time was spent cloningresolveContext.stack
duringdoResolve
; replacing with a singly-linked list reduces the total memory footprint and makes adding a new entry be O(1) in both time and memory, in exchange for making the circularity check be O(n).Additionally, this avoids allocating strings for the formatted stack until required when logging it.
Local profiling showed a reduction from 2400ms of self time in
doResolve
to 88ms of self time plus 73ms for the cost ofhasStackEntry
, a net reduction of 2239ms.Measured on NodeJS 18.19.1.
Note that this is a breaking change that will require an update to webpack's
ResolverCachePlugin
.