-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove sponsored tiles from horizontal shelf #100
Conversation
b1f1de5
to
8ba6380
Compare
May I suggest moving the changes related to dev UX to a separate PR? There's a few more related changes that I had in mind. Namely updating dependencies and using |
By dev UX, do you mean the UPDATE: Removed everything unrelated to the title of the PR. |
8ba6380
to
0148c1e
Compare
I just realized that the same sponsored tile also appears in search result - i have pushed another commit to fix that as well |
Have you tested this? If so, on what webOS version? |
245f4e2
to
ba5d771
Compare
Yes, I tested it on this device: |
I build and deploy the app after this PR got fixed and I still see the sponsored tile on my LG WebOS 3 TV |
I have started seeing them again as well. I think YouTube responses have changed overtime. |
If you have more than one account it can also appear for one but not the other |
I'll dig into this more and raise another PR - it might not be that YouTube changed their response, but it is possible that I missed some of the cases. |
Could parts of #93 help to block that tile again? |
If you open up YouTube TV with a specific User-Agent (which my LG TV has), it shows sponsored tile like this:
Home Page
### Search ResultI tried with a couple of other user-agents from this source, and it didn't show me this sponsored tile, but I always got it with the above user-agent.
The fix is simple - look for
adSlotRenderer
key, and remove it while parsing JSON.