Merge pull request #242 from fire332/fix-ytaf-ui-click

fix checkbox click in the YTAF config UI
webosbrew · Dec 25, 2024 · 98f6c61 · 98f6c61
2 parents 4652116 + bd438c1
commit 98f6c61
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/ui.js b/src/ui.js
@@ -98,10 +98,14 @@ function createOptionsPanel() {
       } else if (evt.keyCode === 13) {
         // "OK" button
 
-        // The YouTube app generates these "OK" events from clicks (including
-        // with the Magic Remote), and we don't want to send a duplicate click
-        // event for those. It seems isTrusted is only true for "real" events.
-        if (evt.isTrusted === true) {
+        /**
+         * The YouTube app generates these "OK" events from clicks (including
+         * with the Magic Remote), and we don't want to send a duplicate click
+         * event for those. Youtube uses the `Event` class instead of
+         * `KeyboardEvent` so we check for that.
+         * See issue #143 and #200 for context.
+         */
+        if (evt instanceof KeyboardEvent) {
           document.activeElement.click();
         }
       } else if (evt.keyCode === 27) {