Bug fix: Correct linking for list/range iterations #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some uses of "for each" in algorithms were linking to the map iteration definition in Infra. Fix this to point at the list iteration definition. Today I learned: this applies to iteration over ranges too! Also updated coding conventions to cover these cases.
wchao1115
approved these changes
Jan 27, 2024
github-actions bot
added a commit
that referenced
this pull request
Jan 27, 2024
SHA: c050f31 Reason: push, by wchao1115 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this pull request
Jan 30, 2024
…g#527) Some uses of "for each" in algorithms were linking to the map iteration definition in Infra. Fix this to point at the list iteration definition. Today I learned: this applies to iteration over ranges too! Also updated coding conventions to cover these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some uses of "for each" in algorithms were linking to the map iteration definition in Infra. Fix this to point at the list iteration definition. Today I learned: this applies to iteration over ranges too!
Also updated coding conventions to cover these cases.
Preview | Diff