Wording change: Streamline context creation and validation algorithms #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that there's still discussion in #498 (e.g. about the concept of context validity) so this is probably not a slam dunk to merge, but I wanted the artifact up to spur the discussion. |
|
Looks more compact, good. |
zolkis
approved these changes
Jan 18, 2024
huningxin
reviewed
Jan 24, 2024
inexorabletash
force-pushed
the
bugfix-context-creation
branch
from
3d25992 to
f76ad2b
Compare
Bundle validation right into context creation, rather than making it a separate step. Note that with the removal of the "validate MLContext" algorithm, a handful of the internal enum members are never referenced; they are implicitly mapped to identical enums defined in Web IDL. This is discussed in webmachinelearning#497 which proposes de-duping the enums. In the mean time, the definitions are marked with "ignore" to silence warnings about unreferenced defnitions. Fixes webmachinelearning#498
inexorabletash
force-pushed
the
bugfix-context-creation
branch
from
f76ad2b to
99ca098
Compare
|
Rebased, should be ready to go now. |
anssiko
approved these changes
Jan 25, 2024
|
@inexorabletash Just checking if you can merge the change yourself, or whether you need me to click the button for you. |
Nope, I can't merge - someone with "Write" permissions needs to do it. I don't even have "Triage" ! |
|
To be explicit, @wchao1115 - a click on this and any other "approved" PRs with no open discussion would be very appreciated. |
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this pull request
Jan 30, 2024
…webmachinelearning#519) Bundle validation right into context creation, rather than making it a separate step. Note that with the removal of the "validate MLContext" algorithm, a handful of the internal enum members are never referenced; they are implicitly mapped to identical enums defined in Web IDL. This is discussed in webmachinelearning#497 which proposes de-duping the enums. In the mean time, the definitions are marked with "ignore" to silence warnings about unreferenced defnitions. Fixes webmachinelearning#498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle validation right into context creation, rather than making it a separate step.
Fixes #498
Preview | Diff