Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a handful of markdown glitches, probably c/o a find/replace. #491

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Dec 14, 2023

  • Missing spaces in "itthrows"
  • "lensizeth" ("size" appearing in the middle of "length")

That said, definition of "bias" is a little sketchy:

An MLOperand. Specifies the 1-D tensor of the bias values whose size is equal to the size of the feature dimension of the input. For example, for an input tensor with nchw layout, the size is the value of input.[[descriptor]].dimensions[1].

"size is the value..." reads like it's trying to define size, so a link to Infra's list/size doesn't make sense. I think this is trying to say that the size of the passed bias (a 1-D tensor) must match the dimension of the input, but without phrasing it as normative behavior.

Maybe this should just be:

An MLOperand. Specifies the 1-D tensor of the bias values whose size is equal to input.[[descriptor]].dimensions[1].

(This still reads as something informative rather than normative, and I don't see where the behavior would be enforced, but that's probably out of scope for a glitch fix.)


Preview | Diff

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@huningxin
Copy link
Contributor

huningxin commented Dec 15, 2023

An MLOperand. Specifies the 1-D tensor of the bias values whose size is equal to input.[[descriptor]].dimensions[1].

"size is equal to" sounds good. But its size doesn't always match input.[[descriptor]].dimensions[1]. It would depend on which dimension is the feature/channel dimension. For "nchw" input layout, it is input.[[descriptor]].dimensions[1], while for "nhwc" input layout, it is input.[[descriptor]].dimensions[3].

@inexorabletash
Copy link
Member Author

PR updated with a change from "size is the value of" to "size is equal to" in two places.

@huningxin can you take another look? Thanks for your patience!

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@huningxin huningxin merged commit e5eb2ca into webmachinelearning:main Dec 16, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Dec 16, 2023
SHA: e5eb2ca
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the typofixes branch December 16, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants