Skip to content

Commit

Permalink
[Headless]: Fix Forced Colors Tests for Headless Shell
Browse files Browse the repository at this point in the history
This CL resolves issues with the forced colors mode tests in the
headless shell test environment. The errors occurred because the link
color in some reference files was not explicitly set to "VisitedText",
as is currently done in forced colors mode. Consequently, many actual
results did not match the expected results solely due to the link color
discrepancy. For more details, refer to this test bucket[1].

Most errors in the Windows scenario should be resolved with this
change, except for `forced-colors-mode-03.html`, which requires further
restructuring based on recent findings about the test's structure. This
will be addressed in a subsequent CL.

Failures on MacOS and Linux platforms will also be handled in a
subsequent CL.

[1]: https://chromium-layout-test-archives.storage.googleapis.com/results.html?json=chromium/ci/win10-wpt-chromium-rel/3919/headless_shell_wpt_tests_include_all%20%28experimental%29/full_results_jsonp.js

Bug: 368396826
Change-Id: Ifc925637e0f1438a5241017de7a2f3023380997e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012900
Reviewed-by: Alison Maher <[email protected]>
Commit-Queue: Sam Davis Omekara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382010}
  • Loading branch information
Sam Davis Omekara authored and chromium-wpt-export-bot committed Nov 12, 2024
1 parent b6027ab commit 2b25844
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
#a {
background-color: Canvas;
}
#a a {
color: LinkText;
}
</style>
<body>
<div id="a">
Expand Down
1 change: 1 addition & 0 deletions forced-colors-mode/forced-colors-mode-36-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
fill: CanvasText;
forced-color-adjust: none;
stroke: LinkText;
color: VisitedText;
}
</style>
<a href="">
Expand Down
1 change: 1 addition & 0 deletions forced-colors-mode/forced-colors-mode-37-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
column-gap: 40px;
column-rule-color: VisitedText;
column-rule-style: solid;
color: VisitedText;
}
</style>
<a href="">
Expand Down
1 change: 1 addition & 0 deletions forced-colors-mode/forced-colors-mode-38-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
column-gap: 40px;
column-rule-color: GrayText;
column-rule-style: solid;
color: VisitedText;
}
</style>
<a href="">
Expand Down
1 change: 1 addition & 0 deletions forced-colors-mode/forced-colors-mode-42-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
a {
caret-color: VisitedText;
forced-color-adjust: none;
color: VisitedText;
}
[contenteditable] {
outline: none;
Expand Down
1 change: 1 addition & 0 deletions forced-colors-mode/forced-colors-mode-44-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
a {
caret-color: GrayText;
forced-color-adjust: none;
color: VisitedText;
}
[contenteditable] {
outline: none;
Expand Down

0 comments on commit 2b25844

Please sign in to comment.