-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Headless]: Fix Forced Colors Tests for Headless Shell
This CL resolves issues with the forced colors mode tests in the headless shell test environment. The errors occurred because the link color in some reference files was not explicitly set to "VisitedText", as is currently done in forced colors mode. Consequently, many actual results did not match the expected results solely due to the link color discrepancy. For more details, refer to this test bucket[1]. Most errors in the Windows scenario should be resolved with this change, except for `forced-colors-mode-03.html`, which requires further restructuring based on recent findings about the test's structure. This will be addressed in a subsequent CL. Failures on MacOS and Linux platforms will also be handled in a subsequent CL. [1]: https://chromium-layout-test-archives.storage.googleapis.com/results.html?json=chromium/ci/win10-wpt-chromium-rel/3919/headless_shell_wpt_tests_include_all%20%28experimental%29/full_results_jsonp.js Bug: 368396826 Change-Id: Ifc925637e0f1438a5241017de7a2f3023380997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012900 Reviewed-by: Alison Maher <[email protected]> Commit-Queue: Sam Davis Omekara <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382010}
- Loading branch information
1 parent
b6027ab
commit 2b25844
Showing
6 changed files
with
8 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,9 @@ | |
#a { | ||
background-color: Canvas; | ||
} | ||
#a a { | ||
color: LinkText; | ||
} | ||
</style> | ||
<body> | ||
<div id="a"> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters