fix: Add clear error message for missing 'version' in package.json #242
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces error handling improvements for cases where the 'version' key is absent in package.json. Previously, the error thrown did not clearly indicate the issue was related to the missing 'version' key, leading to confusion. Now, the application checks for the 'version' key early in the command execution process and provides a clear and descriptive error message if it is not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where the absence of the version key in package.json resulted in an unclear and misleading error message.
Previously, when executing CLI commands such as
yalc publishoryalc addwithout a version key in package.json, the application threw a generic TypeError related to path operations, which did not directly indicate the actual problem.Benefits:
This update ensures that users receive a straightforward and informative error message, making it easier to diagnose configuration issues in their projects. By improving the clarity of error messages, we enhance the user experience and reduce potential confusion during package management tasks.
Link to Issue:
Issue 241
CC: @wclr