chore: fix, provider initiates lattice nats connection with seed and … #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jwt provided by host in-case lattice requires it, if not then default to using only nats-url.
brooksmtownsend
approved these changes
Jan 23, 2025
|
Looks good to me @Solverj, looks like you'll just need to sign off your commits (see details in https://github.com/wasmCloud/go/pull/179/checks?check_run_id=36058847245) and mark this as "ready for review" and we can get this merged |
joonas
reviewed
Jan 23, 2025
Comment on lines
+156
to
+164
| var nc *nats.Conn | ||
| if hostData.LatticeRPCUserSeed != "" && hostData.LatticeRPCUserJWT != "" { | ||
| opts := nats.UserJWTAndSeed(hostData.LatticeRPCUserJWT, hostData.LatticeRPCUserSeed) | ||
| logger.Debug("connecting to nats with userJWTAndSeed") | ||
| nc, err = nats.Connect(hostData.LatticeRPCURL, opts) | ||
| } else { | ||
| logger.Debug("connecting to nats", "url", hostData.LatticeRPCURL) | ||
| nc, err = nats.Connect(hostData.LatticeRPCURL) | ||
| } |
There was a problem hiding this comment.
It might be preferable to connect once, optionally providing connection options if the appropriate configuration is available, something like:
var ncopts []nats.Option
if hostData.LatticeRPCUserSeed != "" && hostData.LatticeRPCUserJWT != "" {
logger.Debug("Using UserJWT and Seed for connection")
ncopts = append(ncopts, nats.UserJWTAndSeed(hostData.LatticeRPCUserJWT, hostData.LatticeRPCUserSeed))
}
nc, err = nats.Connect(hostData.LatticeRPCURL, ncopts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider now initiates nats lattice connection in-case host provides jwt and seed, if not default to only connecting using nats-url.
Feature or Problem
Provider fails with: Failed to connect to NATS: authorization violation: nats: authorization violation
when using provider and lattice requires credentials authentication
Related Issues
Resolves:
#176
Release Information
next release
Consumer Impact
Shouldn't be any blast radius as you're not allowed to start a wasmcloud host without a nats connection.
Testing
Testing it right now, will update from draft when done. Tried it only through vendor editing.
Unit Test(s)
N/A
Acceptance or Integration
N/A
Manual Verification
Attached a custom provider to a component which before the change, had no nats credentials towards the lattice which failed.
Tried with this change, and it now works as expected.