feat(examples): Adds http-keyvalue-bus component example #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Gregory <[email protected]>
Signed-off-by: Eric Gregory <[email protected]>
|
Streamlined in several ways to improve clarity and reduce lines of code:
|
lxfontes
reviewed
Jan 21, 2025
| func kvHandler(w http.ResponseWriter, r *http.Request, ps httprouter.Params) { | ||
| logger := wasilog.ContextLogger("kvHandler") | ||
|
|
||
| // Return if the kv parameter doesn't specify one of our KV providers. |
There was a problem hiding this comment.
IMO: This is not wrong/bad but think it was based on our Rust implementation and would be simpler to provide 2 wadm yamls instead of runtime linking. one for redis and one for nats, both going thru default link.
Runtime linking is nuanced and we don't use it very often. codesearch
With TinyGo .33 and large wasm-collider https://github.com/lxfontes/lwc/blob/main/probe/main.go#L35 we saw situations where repointing the link locked up the component. slightly different situation due to long tail-calls but still strange.
It's also one of those 🤔 features that might change/go-away as wasip3 comes along.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Key-value counter with wasmCloud bus example to demonstrate link definition via
wasmcloud:bus.