Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for #118 #120

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Tests for #118 #120

merged 2 commits into from
Dec 9, 2023

Conversation

lubomudr
Copy link
Contributor

@lubomudr lubomudr commented Dec 9, 2023

Hi

Tests and additional check for PR #118

@lubomudr
Copy link
Contributor Author

lubomudr commented Dec 9, 2023

Still, the question remains, what to do with requests like /bar?arg1&arg2 (without = value)
NGINX does not pass them through $arg_* variables, but you can get the entire argument string through $args, $request, etc.
But if you throw exception 12 (invalid request), then quite a lot will fire at once
Of course, all this can be registered through a white list (and this is probably correct), but this will break many working configurations
On the other hand, this will help to find not very correct queries and convey information to developers

@wargio
Copy link
Owner

wargio commented Dec 9, 2023

i think those ?arg1&arg2 are ok.

@wargio wargio merged commit c34e49f into wargio:main Dec 9, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants