-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto chunking for HDF5 #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the functionality, but I think we can accomplish this all by just changing line 184 to 'chunks': True if auto_chunk else tuple(chunk_size)
, since chunk_size
isn't used for anything other than populating opts
.
My only other concern is that we haven't provided a way to invoke this option, since it isn't activated by default. Should we add the option to save_h5_file
, save_file
, and save_to_disk_func
and kspaceFirstOrder3D
? This way you could invoke it by calling output = kspaceFirstOrder3D(..., auto_chunk=True)
At first glance, I see no reason to not always use auto chunking. This would greatly simplify the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
@peterhollender @djps and I have made some changes based on your suggestions. Thanks for your input! |
could close #173 - it remains an open question what the default chunking should be though.