Update record_reader.py to remove warnings #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the best I can do for the time being. It would seem many methods are not careful about zero division, but this is also the case in MATLAB, so fixing k-wave-python breaks tests. |
| @@ -2720,6 +2726,8 @@ def calculate_axial_pressure() -> float: | |||
| def calculate_lateral_pressure() -> float: | |||
| # calculate magnitude of the lateral pressure at the geometric focus | |||
| Z = k * lateral_positions * diameter / (2 * radius) | |||
| # TODO: this should work | |||
| # assert np.all(Z) > 0, 'Z must be greater than 0' | |||
There was a problem hiding this comment.
Why not to enable this check?
|
Sorry for keeping this PR unreviewed for such a long time! |
…-python into clean-up-pytest-warnings
…-python into clean-up-pytest-warnings
…-python into clean-up-pytest-warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.