optimization(win32-api): BufferTypeFactory()

waitingsong · Jun 28, 2022 · ea17275 · ea17275
1 parent 8ee97d3
commit ea17275
Showing 1 changed file with 30 additions and 29 deletions.
diff --git a/packages/win32-api/src/lib/fixed-buffer.ts b/packages/win32-api/src/lib/fixed-buffer.ts
@@ -19,43 +19,44 @@ export interface BufferType extends Type {
  * @ref https://gist.github.com/TooTallNate/80ac2d94b950216a2705
  */
 export function BufferTypeFactory(length: number, encoding?: BufferEncoding): BufferType {
+  assert(length >= 0)
+
   const inst = Object.create(types.byte, {
     constructor: {
       configurable: true,
       enumerable: false,
       writable: true,
       value: BufferTypeFactory,
     },
-  }) as BufferType
 
-  Object.defineProperty(inst, 'size', {
-    configurable: true,
-    enumerable: true,
-    writable: false,
-    value: length,
-  })
-
-  Object.defineProperty(inst, 'encoding', {
-    configurable: true,
-    enumerable: true,
-    writable: true,
-    value: encoding,
-  })
-
-
-  Object.defineProperty(inst, 'get', {
-    configurable: true,
-    enumerable: true,
-    writable: true,
-    value: getFn,
-  })
-
-  Object.defineProperty(inst, 'set', {
-    configurable: true,
-    enumerable: true,
-    writable: true,
-    value: setFn,
-  })
+    size: {
+      configurable: true,
+      enumerable: true,
+      writable: false,
+      value: length,
+    },
+
+    encoding: {
+      configurable: true,
+      enumerable: true,
+      writable: true,
+      value: encoding,
+    },
+
+    get: {
+      configurable: true,
+      enumerable: true,
+      writable: true,
+      value: getFn,
+    },
+
+    set: {
+      configurable: true,
+      enumerable: true,
+      writable: true,
+      value: setFn,
+    },
+  }) as BufferType
 
   return inst
 }