Fix fetching evLecture id

wafflestudio · Aug 13, 2024 · 4cd34ce · 4cd34ce
1 parent cf9a2a4
commit 4cd34ce
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/SNUTT-2022/SNUTT/Services/LectureService.swift b/SNUTT-2022/SNUTT/Services/LectureService.swift
@@ -99,11 +99,9 @@ struct LectureService: LectureServiceProtocol {
     }
 
     func getEvLecture(of lecture: Lecture) async throws -> EvLecture? {
-        if let lectureId = lecture.lectureId {
-            let dto = try await reviewRepository.fetchEvLectureInfo(lectureId: lectureId)
-            return .init(from: dto)
-        }
-        return nil
+        let lectureId = lecture.lectureId ?? lecture.id
+        let dto = try await reviewRepository.fetchEvLectureInfo(lectureId: lectureId)
+        return .init(from: dto)
     }
 
     func getBuildingList(of lecture: Lecture) async throws -> [Building] {

diff --git a/SNUTT-2022/SNUTT/Views/Scenes/LectureDetailScene.swift b/SNUTT-2022/SNUTT/Views/Scenes/LectureDetailScene.swift
@@ -91,6 +91,14 @@ struct LectureDetailScene: View {
         .onAppear {
             isMapViewExpanded = viewModel.shouldOpenLectureMapView()
         }
+        .onAppear {
+            Task {
+                if let evLecture = await viewModel.getEvLectureInfo(of: lecture) {
+                    lecture.updateEvLecture(to: evLecture)
+                    viewModel.reloadDetailWebView(detailId: evLecture.evLectureId)
+                }
+            }
+        }
         .onChange(of: isMapViewExpanded) {
             viewModel.setIsMapViewExpanded($0)
         }
@@ -498,14 +506,6 @@ struct LectureDetailScene: View {
                 DetailButton(text: "강의평") {
                     showReviewWebView = true
                 }
-                .onAppear {
-                    Task {
-                        if let evLecture = await viewModel.getEvLectureInfo(of: lecture) {
-                            lecture.updateEvLecture(to: evLecture)
-                            viewModel.reloadDetailWebView(detailId: evLecture.evLectureId)
-                        }
-                    }
-                }
                 .sheet(isPresented: $showReviewWebView) {
                     ReviewScene(viewModel: .init(container: viewModel.container), isMainWebView: false, detailId: lecture.evLecture?.evLectureId)
                         .id(colorScheme)