-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#48 fix Capitalization fix for DID spec #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a great start! Just a few comments: I think the title and headings should not be changed, i.e. remain in uppercase (or "Title Case" - apparently that's what it's called according to Wikipedia).
And could you also fix the remaining terms "Decentralized Identifier", "Decentralized Identifier Registry", and "Service Endpoint"?
Co-Authored-By: Markus Sabadello <[email protected]>
Co-Authored-By: Markus Sabadello <[email protected]>
Co-Authored-By: Markus Sabadello <[email protected]>
Co-Authored-By: Markus Sabadello <[email protected]>
Co-Authored-By: Markus Sabadello <[email protected]>
I can. Not really sure about these one: Do you want to make them lower case as well? |
Yes I think those should be lowercase as well, except in titles or headings. To be consistent with the DID Core spec.. |
@peacekeeper @dmitrizagidulin suggest closing stale PR with merge conflicts. |
@mskuybeda -- If you can resolve the merge conflicts, this will likely be merged to the main branch, and your contribution recorded and appreciated. If you cannot resolve the merge conflicts, this will likely be closed without being merged, and your contribution lost to the sands of time. |
This was discussed during the WG meeting on 2024-08-22: |
This was discussed during the #did meeting on 12 September 2024. |
For readability, I prefer the title case. However, most of the standards seem to be lower case and it's better to be uniform. |
This was discussed during the #did meeting on 19 September 2024. View the transcriptw3c/did-resolution#49 Issue#48 fix Capitalization fix for DID spec<markus_sabadello> https://github.com/w3c/did-resolution/issues?q=is%3Aopen+is%3Aissue+label%3Apending-close markus_sabadello: Closing the above issues after this call. <markus_sabadello> w3c/did-resolution#29 markus_sabadello: A couple of other issues I would like to mark pending close <manu> +1 to closing this one <Wip> +1 to closing <markus_sabadello> w3c/did-resolution#30 markus_sabadello: Also issue 30 that can be marked pending close. It is about dereferencing and whose responsibility it is <manu> +1 to closing this one as well markus_sabadello: I marked a couple of issues as good first issues. COntributions welcome. markus_sabadello: These issues are about the relationship between DID core and DID resolution <manu> +1 to explaining relationships |
Closing, as discussed in today's DID WG meeting. |
Fixed capitalization for DID parameter